feat: support generics #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wxh16144
reviewed
Dec 8, 2023
Wxh16144
approved these changes
Dec 8, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
===========================================
+ Coverage 98.26% 100.00% +1.73%
===========================================
Files 2 2
Lines 115 114 -1
Branches 27 27
===========================================
+ Hits 113 114 +1
+ Misses 2 0 -2 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Dec 20, 2023
|
@zombieJ 怎么样了 |
|
覆盖率掉了 |
没改业务代码，应该是加了代码行，导致看起来掉了，我回头看下 |
有样式 |
|
@afc163 移除了 disbaled 判断，这个代码不会被执行到 |
|
没改组件内部代码 |
|
还是要补一下用例，覆盖率要保证不降。 |
vagusX
approved these changes
Jan 2, 2024
vagusX
reviewed
Jan 2, 2024
20 tasks
|
冲突了 |
|
这还重复工作了？ #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.