Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript error in SinglePickerPanelProps interface #765

Closed
wants to merge 1 commit into from

Conversation

chaiwei
Copy link

@chaiwei chaiwei commented Feb 23, 2024

Description:

This pull request addresses the TypeScript error reported in issue #764.

Changes Made:

  • Modified the SinglePickerPanelProps interface to resolve the TypeScript error.
  • Replaced the interface extension with a type intersection, ensuring compatibility with the BasePickerPanelProps interface.

Details:

The TypeScript error occurred due to an incorrect extension of the SinglePickerPanelProps interface, specifically relating to the defaultValue property.

To resolve this issue, the interface extension was replaced with a type intersection, aligning the SinglePickerPanelProps interface with the expected types in the BasePickerPanelProps interface.

Additional Notes:
Tested locally to ensure that the build process completes successfully without encountering TypeScript errors.

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 6:30am

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (73032a3) to head (bb00992).
Report is 88 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #765   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          63       63           
  Lines        2538     2538           
  Branches      672      672           
=======================================
  Hits         2502     2502           
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Oct 22, 2024

Fixed in latest version already: codesandbox.io/p/devbox/singlepickerpanelprops-forked-txzhjt?file=%2Fsrc%2FApp.tsx%3A18%2C18&workspaceId=fb8d496a-cbdc-482b-9003-b38c3155f290

@chaiwei chaiwei closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants