Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error on picker prop #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucasAlencarCosta
Copy link

When passing picker prop that is not ' date' | undefined It throws a TS error even though other props are accepted by the component such as "month" or "year".

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 7:41pm

@LucasAlencarCosta LucasAlencarCosta changed the title fix type error on picker prop fix: type error on picker prop Sep 20, 2023
@@ -99,7 +99,7 @@ export type PickerPanelBaseProps<DateType> = {
} & PickerPanelSharedProps<DateType>;

export type PickerPanelDateProps<DateType> = {
picker?: 'date';
picker?: 'time' | 'date' | 'week' | 'month' | 'year';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type PickerPanelDateProps is works for date only.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #677 (f1d3bea) into master (efc0bfd) will not change coverage.
Report is 7 commits behind head on master.
The diff coverage is n/a.

❗ Current head f1d3bea differs from pull request most recent head 8a97d43. Consider uploading reports for the commit 8a97d43 to get more accurate results

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          56       56           
  Lines        2443     2443           
  Branches      734      728    -6     
=======================================
  Hits         2417     2417           
  Misses         24       24           
  Partials        2        2           
Files Coverage Δ
src/PickerPanel.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163
Copy link
Member

afc163 commented Jun 10, 2024

Conflicting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants