Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower level triggerSubMenuAction wins over upper level triggerSubMenuAction #368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

llambanna
Copy link

to cater for scenario where top level items are click and sub menus are hover - similar to google docs menu UX

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #368 (af68058) into master (8085da9) will decrease coverage by 0.20%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   95.73%   95.53%   -0.21%     
==========================================
  Files          11       11              
  Lines         915      918       +3     
  Branches      271      274       +3     
==========================================
+ Hits          876      877       +1     
- Misses         39       40       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/SubPopupMenu.tsx 95.29% <33.33%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8085da9...af68058. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Feb 12, 2021

Test case is needed.

@delete-merged-branch delete-merged-branch bot deleted the branch react-component:master March 31, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants