Change the priorities of defaultChecked and checked #221
Conversation
src/index.jsx
Outdated
| @@ -21,7 +21,7 @@ class Checkbox extends Component { | |||
| constructor(props) { | |||
| super(props); | |||
|
|
|||
| const checked = 'checked' in props ? props.checked : props.defaultChecked; | |||
| const checked = 'defaultChecked' in props ? props.defaultChecked : 'checked' in props ? props.checked : false; | |||
There was a problem hiding this comment.
Can the double ternary operator be avoided?
There was a problem hiding this comment.
It is wrong to read defaultChecked before checked, checked should be top priority.
There was a problem hiding this comment.
I need to look at the code again🧎♂️。I will reopen this pr after I fix it。
|
Test case needed. |
👌 |
|
There is no need to create another PR, just continue to push your changes. |
|
when the checked value is undefined or null, input will ignore this property,I changed the code follow this principle. There's another question, ‘// eslint-disable-next-line import/no-extraneous-dependencies’ ,when this code exist,it will commit failed,the termminal reported an error: 'Definition for rule 'import/no-extraneous-dependencies' was not found ',what should I do?🧎♂️ |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#35130
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge