Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner implementation #10

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Cleaner implementation #10

wants to merge 6 commits into from

Commits on Sep 25, 2020

  1. simplify checking for observedNodes' changes

    @gabeklein
    gabeklein committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    70de8f2 View commit details
    Browse the repository at this point in the history

  2. tighten up types

    @gabeklein
    gabeklein committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    234afce View commit details
    Browse the repository at this point in the history

  3. optimize main loop

    @gabeklein
    gabeklein committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    423ab4a View commit details
    Browse the repository at this point in the history

  4. store callbacks in a Set instead of array

    @gabeklein
    gabeklein committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    57101bd View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. use a closure to assist unobserve

    @gabeklein
    gabeklein committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    1d31a22 View commit details
    Browse the repository at this point in the history

  2. indent w spaces instead

    @gabeklein
    gabeklein committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    2459deb View commit details
    Browse the repository at this point in the history