Add metering to the VM #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdunnington
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Nice! Overall this looks really solid. Adding some tests to the test-unit suite sounds great to keep the feature stable. I wouldn't worry too much about making sure the debug functionality is tested unless you really want to - it's still an untested experimental feature, so you may be breaking new ground there and finding bugs with it. 😅
rdunnington
reviewed
Jun 13, 2024
rdunnington
reviewed
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for metering the virtual machine. The meter can be set when you invoke or resume the VM. In the preamble it will decrease the meter and if it runs out, return an error and save state so that the VM can resume from where it was interrupted.
It currently compiles and the tests pass. Wanted to get a draft pr up to get your initial thoughts. I want to revisit some of the places where we have both debug state and meter state and make sure the interactions between the two are good. I'll also add some tests with metering state with and without debug as well. It's not a trivial interaction between the two so I want to make sure we have it tested.