Memory leak fixes, code reorg, plus a very WIP register VM

bench/main.zig

@@ -25,7 +25,7 @@ fn run(allocator: std.mem.Allocator, benchmark: Benchmark) !void {
     defer module_def.deinit();
     try module_def.decode(wasm_data);
 
-    var module_instance = bytebox.ModuleInstance.init(&module_def, allocator);
+    var module_instance = try bytebox.ModuleInstance.init(&module_def, allocator);
     defer module_instance.deinit();
     try module_instance.instantiate(.{});
 

run/main.zig

@@ -253,7 +253,7 @@ pub fn main() !void {
         return;
     }
 
-    var module_instance = bytebox.ModuleInstance.init(&module_def, allocator);
+    var module_instance = try bytebox.ModuleInstance.init(&module_def, allocator);
     defer module_instance.deinit();
 
     var imports_wasi: bytebox.ModuleImportPackage = try wasi.initImports(.{
@@ -353,7 +353,7 @@ pub fn main() !void {
     var returns = std.ArrayList(bytebox.Val).init(allocator);
     try returns.resize(func_export.returns.len);
 
-    module_instance.invoke(func_handle, params.items, returns.items, .{}) catch |e| {
+    module_instance.invoke(func_handle, params.items.ptr, returns.items.ptr, .{}) catch |e| {
         var backtrace = module_instance.formatBacktrace(1, allocator) catch unreachable;
         std.log.err("Caught {} during function invoke. Backtrace:\n{s}\n", .{ e, backtrace.items });
         backtrace.deinit();

src/cffi.zig

@@ -1,13 +1,15 @@
 const std = @import("std");
-const core = @import("core.zig");
-const StableArray = @import("zig-stable-array/stable_array.zig").StableArray;
+const AllocError = std.mem.Allocator.Error;
 
+const core = @import("core.zig");
 const ValType = core.ValType;
 const Val = core.Val;
 const ModuleDefinition = core.ModuleDefinition;
 const ModuleInstance = core.ModuleInstance;
 const ModuleImportPackage = core.ModuleImportPackage;
 
+const StableArray = @import("zig-stable-array/stable_array.zig").StableArray;
+
 // C interface
 const CSlice = extern struct {
     data: ?[*]u8,
@@ -348,7 +350,10 @@ export fn bb_module_instance_init(module_definition: ?*ModuleDefinition) ?*Modul
         module = allocator.create(core.ModuleInstance) catch null;
 
         if (module) |m| {
-            m.* = core.ModuleInstance.init(module_definition.?, allocator);
+            m.* = core.ModuleInstance.init(module_definition.?, allocator) catch {
+                // TODO log out of memory?
+                return null;
+            };
         }
     }
 
@@ -462,14 +467,14 @@ export fn bb_module_instance_invoke(module: ?*ModuleInstance, c_handle: CFuncHan
             .type = @as(core.FunctionHandleType, @enumFromInt(c_handle.type)),
         };
 
-        const invoke_opts = core.ModuleInstance.InvokeOpts{
+        const invoke_opts = core.InvokeOpts{
             .trap_on_start = opts.trap_on_start,
         };
 
         var params_slice: []const Val = if (params != null) params.?[0..num_params] else &[_]Val{};
         var returns_slice: []Val = if (returns != null) returns.?[0..num_returns] else &[_]Val{};
 
-        if (module.?.invoke(handle, params_slice, returns_slice, invoke_opts)) {
+        if (module.?.invoke(handle, params_slice.ptr, returns_slice.ptr, invoke_opts)) {
             return CError.Ok;
         } else |err| {
             return translateError(err);

src/common.zig

@@ -1,5 +1,8 @@
+// Lowest layer of the codebase, that contains types and code used in higher layers
+
 const std = @import("std");
-const StableArray = @import("zig-stable-array/stable_array.zig").StableArray;
+
+pub const StableArray = @import("zig-stable-array/stable_array.zig").StableArray;
 
 pub fn decodeLEB128(comptime T: type, reader: anytype) !T {
     if (@typeInfo(T).Int.signedness == .signed) {