Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segmentation fault on invalid SMARTS #19

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix segmentation fault on invalid SMARTS #19

wants to merge 9 commits into from

Commits on Dec 4, 2023

  1. Add error handling to RWMol::from_smarts

    @aleebberg
    aleebberg committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d60d2ae View commit details
    Browse the repository at this point in the history

  2. Add test for invalid input

    @aleebberg
    aleebberg committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d8d0b7d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. add empty SMARTS handling and facilitate errors

    @aleebberg
    aleebberg committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    d12879f View commit details
    Browse the repository at this point in the history

  2. Adapt error handling and add tests für empty SMARTS

    @aleebberg
    aleebberg committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f6da32a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Add enum error handling

    @aleebberg
    aleebberg committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8eea60f View commit details
    Browse the repository at this point in the history

  2. Adapt tests to enum errors

    @aleebberg
    aleebberg committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a9c9e84 View commit details
    Browse the repository at this point in the history

  3. Make romol mut

    @aleebberg
    aleebberg committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    27ded30 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Run linter

    @aleebberg
    aleebberg committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    79d9b4e View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Remove empty smarts error

    @aleebberg
    aleebberg committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    5461f0c View commit details
    Browse the repository at this point in the history