PR: #42:Fixing the negative scenarios in ut_kvp_getListCount()

.vscode/launch.json

@@ -8,9 +8,9 @@
       "args": [],
       "stopAtEntry": false,
       "externalConsole": false,
-      "cwd": "${workspaceFolder}/tests/bin/",
-      "program": "${workspaceFolder}/tests/bin/ut_control_test",
-      "environment": [ {"name": "LD_LIBRARY_PATH", "value":"${workspaceFolder}/tests/bin/"} ],
+      "cwd": "${workspaceFolder}/tests/build/bin/",
+      "program": "${workspaceFolder}/tests/build/bin/ut_control_test",
+      "environment": [ {"name": "LD_LIBRARY_PATH", "value":"${workspaceFolder}/tests/build/bin/"} ],
       "MIMode": "gdb",
       "miDebuggerPath": "gdb",
       "setupCommands": [

src/ut_kvp.c

@@ -598,14 +598,16 @@ uint32_t ut_kvp_getListCount( ut_kvp_instance_t *pInstance, const char *pszKey)
         return 0;
     }
 
-    if (fy_node_is_sequence(node))
+    if (fy_node_is_sequence(node) == false)
     {
-        count = fy_node_sequence_item_count(node);
-        if (count == -1)
-        {
-            UT_LOG_ERROR("fy_node_sequence_item_count() returned error\n ");
-            return 0;
-        }
+        return 0; // Early return on negative check
+    }
+
+    count = fy_node_sequence_item_count(node);
+    if (count == -1)
+    {
+        UT_LOG_ERROR("fy_node_sequence_item_count() returned error\n");
+        return 0;
     }
 
     return count;

tests/build.sh

@@ -28,7 +28,7 @@ NC="\e[39m"
 # When the major version changes in the ut-core, what that signals is that the testings will have to be upgraded to support that version
 # Therefore in that case it warns you but doesnt' chnage to that version, which could cause your tests to break.
 # Change this to upgrade your UT-Core Major versions. Non ABI Changes 1.x.x are supported, between major revisions
-UT_PROJECT_MAJOR_VERSION="3."
+UT_PROJECT_MAJOR_VERSION="4."
 
 # Clone the Unit Test Requirements
 [email protected]:rdkcentral/ut-core.git
@@ -41,16 +41,18 @@ function check_next_revision()
     pushd ./ut-core
     # Set default UT_CORE_PROJECT_VERSION to next revision, if it's set then we don't need to tell you again
     if [ -v ${UT_CORE_PROJECT_VERSION} ]; then
-        UT_CORE_PROJECT_VERSION=$(git tag | grep ^${UT_PROJECT_MAJOR_VERSION} | sort -r | head -n1)
-        UT_NEXT_VERSION=$(git tag | sort -r | head -n1)
+        UT_CORE_PROJECT_VERSION=$(git tag | grep ^${UT_PROJECT_MAJOR_VERSION} | sort -r | head -n1)    # Selects the highest version of the tags starting with ${UT_PROJECT_MAJOR_VERSION}
+        UT_NEXT_VERSION=$(git tag | sort -r | head -n1)						       # Selects the highest version from the tags
+	if [ -z ${UT_CORE_PROJECT_VERSION} ]; then
+		UT_CORE_PROJECT_VERSION="${UT_NEXT_VERSION}"                                           # Fallback if there is no version of tags are available starting with ${UT_PROJECT_MAJOR_VERSION}
+	fi
         echo -e ${YELLOW}ut-core version selected:[${UT_CORE_PROJECT_VERSION}]${NC}
         if [ "${UT_NEXT_VERSION}" != "${UT_CORE_PROJECT_VERSION}" ]; then
             echo -e ${RED}--- New Version of ut-core released [${UT_NEXT_VERSION}] consider upgrading ---${NC}
         fi
     fi
     popd > /dev/null
 }
-
 # Check if the common document configuration is present, if not clone it
 if [ -d "./ut-core" ]; then
     # ut-core exists so run the makefile from ut

tests/src/ut_test_kvp.c

@@ -305,6 +305,9 @@ void test_ut_kvp_list(void)
     uint32_t result;
     int count;
 
+    count = ut_kvp_getListCount(gpMainTestInstance, "decodeTest/checkFloat");
+    UT_ASSERT( count == 0 );
+
     count = ut_kvp_getListCount(gpMainTestInstance, "decodeTest/checkStringList");
     UT_ASSERT( count == 3 );