Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tile): replace Metadata and Tile with recipes #48

Merged
merged 12 commits into from
Sep 24, 2024
Merged

feat(Tile): replace Metadata and Tile with recipes #48

merged 12 commits into from
Sep 24, 2024

Conversation

cee-money
Copy link
Contributor

@cee-money cee-money commented Sep 23, 2024 •
edited
Loading

Description

We've agreed that open source Solid UI should just supply recipes for specialized components like Tile and Metadata, empowering users to create these components in their client code bases when needed. As a result, this PR removes the Tile and Metadata components from open source Solid UI and adds their recipes to Storybook.

Changes

  • Removed Tile
  • Removed Metadata
  • Added directory for each recipe
  • Added recipe for Tile
  • Added recipe for Metadata

Testing

  • fetch feat branch and run locally
  • ensure all stories work as expected
  • interact with new recipes for Tile and Metadata

@cee-money cee-money changed the title feat(Metadata, Tile): replace Tile and Metadata with recipes feat(Metadata Tile): replace Metadata and Tile with recipes Sep 23, 2024
@cee-money cee-money changed the title feat(Metadata Tile): replace Metadata and Tile with recipes feat(Tile): replace Metadata and Tile with recipes Sep 23, 2024
@cee-money cee-money marked this pull request as ready for review September 23, 2024 21:20
@cee-money cee-money mentioned this pull request Sep 24, 2024
Merged
3 tasks
anthony9187
anthony9187 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@anthony9187 anthony9187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@cee-money cee-money merged commit a35886f into main Sep 24, 2024
5 checks passed
@cee-money cee-money deleted the feat/remove-tile-metadata-add-recipes branch September 24, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony9187 anthony9187 anthony9187 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cee-money @anthony9187 @chiefcll