Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): space overwriting previous character #17

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

slhay28
Copy link
Contributor

@slhay28 slhay28 commented Jul 9, 2024

Description

within the KeyboardInput component, it was observed that the space key overrides the last character in the title. This fixes that bug

Changes

  • removes minus 1 from slice formatting input text on space

Testing

In both Input and KeyboardInput, add a few characters and then a space. Make sure the space does not overwrite

@anthony9187
Copy link
Contributor

instead of describing the content of the change in the PR title, let's describe the bug being resolved

@slhay28 slhay28 changed the title fix(Input): removes minus 1 from slice formating input text on space fix(Input): space overwriting previous character Jul 9, 2024
@slhay28 slhay28 merged commit cc192d8 into main Jul 9, 2024
3 checks passed
@anthony9187 anthony9187 deleted the fix/Input-space branch July 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants