fix: add hex transform plugin #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony9187
changed the title
anthony9187
changed the title
anthony9187
changed the title
slhay28
approved these changes
Jul 9, 2024
anthony9187
force-pushed
the
feat/add-hex-transform-plugin
branch
from
22d6b63
to
64866f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the hex transform plugin to the compiler, excluding story files as this breaks storybook's Color controls. This doesn't mean much for us in regards to writing components as we were already providing string colors, it just means that the renderer wont throw errors about it in random places
Changes
hexColorTransformplugin to the vite configTesting
ensure the app runs as expected
ensure colors are rendered as expected