Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fonts): replaces ubuntu with roboto #14

Merged
merged 5 commits into from
Jun 28, 2024
Merged

fix(fonts): replaces ubuntu with roboto #14

merged 5 commits into from
Jun 28, 2024

Conversation

slhay28
Copy link
Contributor

@slhay28 slhay28 commented Jun 28, 2024

Description

replaces ubuntu with roboto

Changes

  • replaces ubuntu with roboto

Testing

make sure all fonts render as expected

@rdkcmf-jenkins
Copy link

Copyright scan failure

Commit: af73c28
Report detail: https://gist.github.com/rdkcmf-jenkins/86aee98682f15157e0d866be2d20e455

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/solid-ui/14/rdkcentral/solid-ui

  • Commit: af73c28

Report detail: gist

Copy link
Contributor

@anthony9187 anthony9187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two things:
What are the metrics files used for? do we need them?
we're only using Roboto-Bold and Roboto-Regular in AppCoreExtensions, can we remove the other versions from the assets?

@rdkcmf-jenkins
Copy link

Copyright scan failure

Commit: 43a9d7a
Report detail: https://gist.github.com/rdkcmf-jenkins/2e4b517170b8800a9c0d965a3350f30b

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/solid-ui/14/rdkcentral/solid-ui

  • Commit: 43a9d7a

Report detail: gist

@rdkcmf-jenkins
Copy link

Copyright scan failure

Commit: 43a9d7a
Report detail: https://gist.github.com/rdkcmf-jenkins/1bf6a42fda60068cdc53f6fc816f599b

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/solid-ui/14/rdkcentral/solid-ui

  • Commit: 43a9d7a

Report detail: gist

@rdkcmf-jenkins
Copy link

Copyright scan failure

Commit: 23fd37b
Report detail: https://gist.github.com/rdkcmf-jenkins/a7ac626d680bab2e39cdc02e9a6469b7

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/solid-ui/14/rdkcentral/solid-ui

  • Commit: 23fd37b

Report detail: gist

@slhay28 slhay28 merged commit 44124b7 into main Jun 28, 2024
0 of 2 checks passed
@anthony9187 anthony9187 deleted the fix/fonts branch July 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants