-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: button uses text align and button container uses flex props #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony9187
changed the title
fix(textAlign): removed align property from button cont and key
fix: removed align property from button cont and key
Jun 27, 2024
ctoddy
changed the title
fix: removed align property from button cont and key
fix: button uses text align and button container uses flex props
Jul 9, 2024
@anthony9187 wanted to confirm, we wanted to keep alignItems for the button strictly center? or was this expected to be a prop users can control with a supporting arg for the Button story? |
ctoddy
commented
Jul 9, 2024
ctoddy
commented
Jul 9, 2024
slhay28
reviewed
Jul 9, 2024
slhay28
reviewed
Jul 9, 2024
slhay28
reviewed
Jul 9, 2024
slhay28
reviewed
Jul 9, 2024
anthony9187
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Button was updated to use textAlign and other supporting props (contain) and buttonContainer strictly uses flex props since textAlign does not work with flex props. Key's now use flex props only.
see LUI-1503
Changes
Testing