Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button uses text align and button container uses flex props #11

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

ctoddy
Copy link
Contributor

@ctoddy ctoddy commented Jun 25, 2024

Description

Button was updated to use textAlign and other supporting props (contain) and buttonContainer strictly uses flex props since textAlign does not work with flex props. Key's now use flex props only.

see LUI-1503

Changes

  • textAlign property removed from Button Container & Key but kept for Button
  • Button Container uses flex props
  • flex props arg removed from Button story

Testing

  • Start local
  • Go to button, observe text is centered
  • Go to button container, observe text and icon is centered
  • Go to key, observe text is centered

@anthony9187 anthony9187 changed the title fix(textAlign): removed align property from button cont and key fix: removed align property from button cont and key Jun 27, 2024
@anthony9187
Copy link
Contributor

noticing some weird behavior

button + flexStart
Screenshot 2024-07-08 at 2 17 13 PM

button + flexEnd
Screenshot 2024-07-08 at 2 17 05 PM

it may actually be the case that textAlign is better for buttons, or we may need to be a little more creative on how we handle justifying the content

@ctoddy ctoddy changed the title fix: removed align property from button cont and key fix: button uses text align and button container uses flex props Jul 9, 2024
@ctoddy
Copy link
Contributor Author

ctoddy commented Jul 9, 2024

@anthony9187 wanted to confirm, we wanted to keep alignItems for the button strictly center? or was this expected to be a prop users can control with a supporting arg for the Button story?

@ctoddy ctoddy merged commit 80e7b0b into main Jul 11, 2024
3 checks passed
@anthony9187 anthony9187 deleted the fix/textAlign branch July 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants