fix: Optimize reuse on Row and Column helpers (#63)

rdkcentral · Oct 7, 2024 · 3ef23a6 · 3ef23a6
1 parent 175a604
commit 3ef23a6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/packages/solid/components/Column/Column.tsx b/packages/solid/components/Column/Column.tsx
@@ -23,11 +23,10 @@ import { chainFunctions } from '../../utils/chainFunctions.js';
 import type { ColumnProps } from './Column.types.js';
 import styles from './Column.styles.js';
 
+const onUp = handleNavigation('up');
+const onDown = handleNavigation('down');
+const scroll = withScrolling(false);
 const Column: Component<ColumnProps> = props => {
-  const onUp = handleNavigation('up');
-  const onDown = handleNavigation('down');
-  const scroll = withScrolling(false);
-
   return (
     <View
       {...props}

diff --git a/packages/solid/components/Row/Row.tsx b/packages/solid/components/Row/Row.tsx
@@ -23,11 +23,11 @@ import { withScrolling } from '../../utils/withScrolling.js';
 import styles from './Row.styles.js';
 import type { RowProps } from './Row.types.js';
 
-const Row: Component<RowProps> = props => {
-  const onLeft = handleNavigation('left');
-  const onRight = handleNavigation('right');
-  const scroll = withScrolling(true);
+const onLeft = handleNavigation('left');
+const onRight = handleNavigation('right');
+const scroll = withScrolling(true);
 
+const Row: Component<RowProps> = props => {
   return (
     <View
       {...props}