Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Native SDK unit tests support framework #223

Merged
merged 12 commits into from
Oct 16, 2024

Conversation

parag-pv
Copy link
Contributor

@parag-pv parag-pv commented Oct 3, 2024

Framework changes in Transport to support event passthrough to JSON engine

@parag-pv parag-pv requested a review from kschrief October 3, 2024 14:23
@ksentak ksentak changed the title Feat: Native SDK Core events unit tests feat: Native SDK unit tests support framework Oct 4, 2024
template <typename RESPONSE>
Firebolt::Error WaitForEventResponse(const uint32_t &id, const string &eventName, RESPONSE &response, const uint32_t waitTime, EventMap& _eventMap)
{
std::cout << "Inside Mock Transport WaitForEventResponse function" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed.

{
std::cout << "Inside Transport WaitForEventResponse function" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed.

@kschrief kschrief merged commit 819cc21 into next Oct 16, 2024
6 checks passed
@kschrief kschrief deleted the feature/native-core-events-unit-tests branch October 16, 2024 15:35
kschrief pushed a commit that referenced this pull request Oct 16, 2024
# [3.2.0-next.4](v3.2.0-next.3...v3.2.0-next.4) (2024-10-16)

### Bug Fixes

* Native SDK unit tests support framework ([#223](#223)) ([819cc21](819cc21))
@kschrief
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants