feat: Start/stop performance metrics collection for each test case without glue code #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue with linting detected. For more information on our linting policies, please see our Linting-Guide. |
| }); | ||
| } else { | ||
| cy.log(CONSTANTS.PERFORMANCE_METRICS_NOT_ACTIVE); | ||
| } |
There was a problem hiding this comment.
why did you remove this code ? This function is to start/stop metrics collection and that should reside in before operation
| }); | ||
| } | ||
| }); | ||
|
|
||
| /** |
There was a problem hiding this comment.
This is not right, why are we stopping metrics collection in aftereach
| @@ -132,8 +123,36 @@ export default function (module) { | |||
| // beforeEach | |||
| beforeEach(() => { | |||
| UTILS.getEnvVariable(CONSTANTS.FB_INTERACTIONLOGS).clearLogs(); | |||
| cy.getBeforeOperationObject(); | |||
| UTILS.destroyGlobalObjects([CONSTANTS.LIFECYCLE_APP_OBJECT_LIST]); | |||
There was a problem hiding this comment.
why are we adding a .then for lines 135 and 136.
You can create a new command which internally creates marker and save start time there. Then that command can be used in beforeeach right
| } | ||
| } else { | ||
| cy.log(CONSTANTS.PERFORMANCE_METRICS_NOT_ACTIVE); | ||
| } |
There was a problem hiding this comment.
line 146 is nto 150 is not correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.