Skip to content

Commit

Permalink
compositorcontroller: fix for -Wreturn-type error (#58)
Browse files Browse the repository at this point in the history
fix for #54 rdkshell crash when built from gcc 9.x or higher

return statement of CompositorController::draw() is missed
as its return type is bool. Upon having a return type but
no return value, rdkshell encounters segmentation fault while
building it on higher version of gcc

Signed-off-by: Moorthy Baskar <[email protected]>
  • Loading branch information
moorthy-bs authored Jan 19, 2021
1 parent 5141207 commit 9a8e5d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions compositorcontroller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,7 @@ namespace RdkShell
gSplashImage->draw();
}
}
return true;
}

bool CompositorController::addAnimation(const std::string& client, double duration, std::map<std::string, RdkShellData> &animationProperties)
Expand Down
1 change: 1 addition & 0 deletions servermessagehandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ namespace RdkShell
{
((ServerMessageHandler*)context)->communicationHandler()->sendMessage(id,message);
}
return true;
}

bool getScaleHandler(int id, const rapidjson::Value& params, void* context)
Expand Down

0 comments on commit 9a8e5d6

Please sign in to comment.