Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow withEditItems to work with lazyScroll #496

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: allow withEditItems to work with lazyScroll #496

wants to merge 2 commits into from

Conversation

joshhowenstine
Copy link
Contributor

@joshhowenstine joshhowenstine commented Mar 27, 2024 •
edited
Loading

Description

An issue was discovered where withEditItems does not integrate smoothly with lazyScroll. This update ensures that the scrolling functionality will pause until the initial item swap transition is complete, thereby preventing any conflict or unexpected behavior during additional logic execution.

Ticket

Testing Instructions

  1. Navigate to the withEditItems story.
  2. Scroll through the row, it should operate as expected.
  3. Press "Enter" to enable edit mode and move the current item. The functionality should remain seamless.
  4. Enable the lazyScroll option in Storybook.
  5. Repeat the above actions. After swapping items, the scrolling animation should now proceed as expected without issues.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

ImCoolNowRight
ImCoolNowRight approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ImCoolNowRight ImCoolNowRight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImCoolNowRight ImCoolNowRight ImCoolNowRight approved these changes

@erautenberg erautenberg erautenberg approved these changes

@anthony9187 anthony9187 Awaiting requested review from anthony9187 anthony9187 is a code owner

@THoj13 THoj13 Awaiting requested review from THoj13

@arwehrman arwehrman Awaiting requested review from arwehrman

@jazzyw jazzyw Awaiting requested review from jazzyw

@soumyaloka soumyaloka Awaiting requested review from soumyaloka soumyaloka is a code owner

@slhay28 slhay28 Awaiting requested review from slhay28

@ctoddy ctoddy Awaiting requested review from ctoddy ctoddy is a code owner

@cee-money cee-money Awaiting requested review from cee-money cee-money is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshhowenstine @svc-lightning-ui-components @ImCoolNowRight @erautenberg