Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated readme #115

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Updated readme #115

merged 4 commits into from
Nov 7, 2023

Conversation

paperclipstudio
Copy link
Contributor

@paperclipstudio paperclipstudio commented Nov 7, 2023 •
edited
Loading

Removed $ from code snippets and added code to setup python virtual environment.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paperclipstudio paperclipstudio marked this pull request as draft November 7, 2023 13:58
@paperclipstudio paperclipstudio changed the title Updated readme, Updated readme Nov 7, 2023
@paperclipstudio paperclipstudio marked this pull request as ready for review November 7, 2023 14:04
TeknoVenus
TeknoVenus approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@TeknoVenus TeknoVenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

As an aside, at some point we should update the Go version used for Ubuntu in the README. 1.13 isn't a requirement, it just so happens to be the version that was current when I wrote the readme... But that's a bit beyond the scope of this PR

@paperclipstudio paperclipstudio mentioned this pull request Nov 7, 2023
Open
@TeknoVenus TeknoVenus merged commit 8022d49 into rdkcentral:master Nov 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeknoVenus TeknoVenus TeknoVenus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paperclipstudio @CLAassistant @TeknoVenus