-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manipulator/grippername to XML reader #1311
Open
Puttichai
wants to merge
13
commits into
production
Choose a base branch
from
update_xml_20230920
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now specified in an xml file
@Puttichai lgtm. changelog? patch version? |
Puttichai
changed the title
Draft: Add manipulator/grippername to XML reader
Add manipulator/grippername to XML reader
Sep 20, 2023
@rdiankov can we merge this quickly? people still find OpenRAVE XML useful to model complicated robot model and this is for it |
…date_xml_20230920
…o update_xml_20230920
…o update_xml_20230920
…o update_xml_20230920
…o update_xml_20230920
…o update_xml_20230920
…o update_xml_20230920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now XML reader can read
grippername
specified undermanipulator
. This is so that a gripper name can be specified directly from an XML file.