Address PR feedback

rdheekonda · Oct 12, 2022 · 76a7b27 · 76a7b27
1 parent 08b59b7
commit 76a7b27
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/setup/setup-ci/security-scanner/README.md b/setup/setup-ci/security-scanner/README.md
@@ -12,7 +12,7 @@ description: Sample setup script to scan Compute Instances for malware and secur
 
 [![license: MIT](https://img.shields.io/badge/License-MIT-purple.svg)](../../../LICENSE)
 
-A security scanner for Azure ML [Compute Instances](https://learn.microsoft.com/en-us/azure/machine-learning/concept-compute-instance) reporting malware and vulnerabilities in OS and Python packages to [Azure Log Analytics](https://learn.microsoft.com/en-us/azure/azure-monitor/logs/log-analytics-overview).
+A security scanner for Azure ML [Compute Instances](https://learn.microsoft.com/en-us/azure/machine-learning/concept-compute-instance) reporting malware and vulnerabilities in OS and Python packages to [Azure Log Analytics](https://learn.microsoft.com/en-us/azure/azure-monitor/logs/log-analytics-overview). For details on the vulnerability management process for the Azure Machine Learning service, see [Vulnerability Management](https://learn.microsoft.com/azure/machine-learning/concept-vulnerability-management).
 
 ## Getting Started
 

diff --git a/setup/setup-ci/security-scanner/tests/amlsecscan.json b/setup/setup-ci/security-scanner/tests/amlsecscan.json
@@ -1,3 +1,3 @@
 {
-    "logAnalyticsResourceId": "/subscriptions/23782349-c970-4549-acbb-7ed9d00ebb32/resourceGroups/DefaultResourceGroup-WUS2/providers/Microsoft.OperationalInsights/workspaces/AmlDev"
+    "logAnalyticsResourceId": "/subscriptions/{subscription_id}/resourceGroups/{resource_group_name}/providers/Microsoft.OperationalInsights/workspaces/{workspace_name}"
 }
diff --git a/setup/setup-ci/security-scanner/tests/deploy.json b/setup/setup-ci/security-scanner/tests/deploy.json
@@ -4,7 +4,7 @@
   "resources": [
     {
       "type": "Microsoft.MachineLearningServices/workspaces/computes",
-      "name": "AmlDev/test-amlsecscan",
+      "name": "{azure_ml_workspace_name}/{azure_ml_compute_name}",
       "location": "westus2",
       "apiVersion": "2021-07-01",
       "properties": {
@@ -19,7 +19,7 @@
             "scripts": {
               "creationScript": {
                 "scriptSource":"inline",
-                "scriptData":"[base64('sudo python3 mmaitre/amlsecscan.py install')]",
+                "scriptData":"[base64('sudo python3 {user_name}/amlsecscan.py install')]",
                 "timeout": "10m"
               }
             }

diff --git a/setup/setup-ci/security-scanner/tests/test_trivy_3.json b/setup/setup-ci/security-scanner/tests/test_trivy_3.json
@@ -1,6 +1,6 @@
 {
   "SchemaVersion": 2,
-  "ArtifactName": "mmaitre-mdc4",
+  "ArtifactName": "test-mdc4",
   "ArtifactType": "filesystem",
   "Metadata": {
     "OS": {
@@ -20,7 +20,7 @@
   },
   "Results": [
     {
-      "Target": "mmaitre-mdc4 (ubuntu 18.04)",
+      "Target": "test-mdc4 (ubuntu 18.04)",
       "Class": "os-pkgs",
       "Type": "ubuntu",
       "Vulnerabilities": [