Remove generic parameters from DataFactory#fromTerm() overloads
#57
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 49b9476 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you @Renegade334. I saw PR DefinitelyTyped/DefinitelyTyped#71645. If we merge this, will we need to do anything to DT? The idea os that v2 is actually backwards-compatible with v1 |
|
@rubensworks maybe we overdid this in #45. The test do not fail so if you cannot think of any uncovered scenario, I say we merge this ASAP and push 2.0.1 |
rubensworks
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #45
The current implementation of the overloads is a little confused – the generics here don't actually do anything, and having multiple generic overloads like this has the potential to cause assignability headaches with the TypeScript compiler.
This change simply removes those generics. The catch-all signature is unnecessary, as all cases are already covered.