Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #48

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Version Packages #48

merged 1 commit into from
Sep 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@rdfjs/[email protected]

Patch Changes

  • a631541: Only package declaration files

@github-actions github-actions bot force-pushed the changeset-release/master branch from ed8aeda to 802b270 Compare September 11, 2024 18:58
@github-actions github-actions bot force-pushed the changeset-release/master branch from 802b270 to 5bf2ab0 Compare September 11, 2024 18:58
@rubensworks
Copy link
Member

For reference, I would like to introduce a breaking change in the query typings.
Once #46 has been merged, could we wait a bit with releasing until the query changes have been incorporated as well?

@tpluscode
Copy link
Contributor

Let's release 1.1.1 now then if we have no changes for 1.x branch?

@rubensworks
Copy link
Member

That works for me!

@tpluscode
Copy link
Contributor

I looked at the currently open PRs and I found none that we can readily merge for 1.x nor open issues which appear to be low-hanging fruit.

Let's merge now?

@rubensworks
Copy link
Member

Yes, go ahead!

@tpluscode tpluscode merged commit 66f7b7d into master Sep 17, 2024
@tpluscode tpluscode deleted the changeset-release/master branch September 17, 2024 07:52
@rubensworks
Copy link
Member

For reference, I would like to introduce a breaking change in the query typings.
Once #46 has been merged, could we wait a bit with releasing until the query changes have been incorporated as well?

@tpluscode My comment above can be ignored. I looked into it, and no breaking changes will be required here.

@tpluscode
Copy link
Contributor

My comment above can be ignored

On the contrary. If we want to include query typings in 1.x then we need to hold off #46 a little longer

@rubensworks
Copy link
Member

That's not needed, no changes in query typings will be needed at all. I thought changes would be required, but I was mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants