feat: add inbetween tests + fix fragment ordering issue with inbetwee… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajuvercr
force-pushed
the
feat/inbetweentests
branch
from
e786fff to
e037f92
Compare
smessie
reviewed
Sep 26, 2024
smessie
reviewed
Sep 27, 2024
lib/condition/condition.ts
Outdated
Comment on lines
115
to
122
| if (this.min === undefined || between.min < this.min) { | ||
| this.min = between.min; | ||
| this.eqMin = true; | ||
| } | ||
| if (this.max === undefined || between.max < this.max) { | ||
| this.max = between.max; | ||
| this.eqMax = false; | ||
| } |
There was a problem hiding this comment.
This more in detail checking + assignments should happen in the add function below, instead of here, because in the constructor there will be no other bounds yet.
lib/condition/condition.ts
Outdated
Comment on lines
168
to
171
| this.min = between.min; | ||
| this.eqMin = true; | ||
| this.max = between.max; | ||
| this.eqMax = false; |
There was a problem hiding this comment.
Here you don't do the detailed assignments. So this should go to the constructor, and the change from the constructor should go here.
ajuvercr
force-pushed
the
feat/inbetweentests
branch
from
d9b9dc8 to
83bede9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n relations
Extract inBetweenRelation parsing to separate file to promote reuse by ordered strategy.