-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch member errors #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ajuvercr
commented
Mar 26, 2024
- Actually use concurrent requests
- cleanup logging a bit
- catch member extract errors
kkostov
reviewed
Mar 29, 2024
kkostov
reviewed
Mar 29, 2024
kkostov
reviewed
Mar 29, 2024
The concurrent requests now also refetch concurrently, which of course then keeps resulting in problems: pieter@pieter-Latitude-7430:~/Projects/LDES-client$ export DEBUG=*;ts-node bin/cli.ts https://marineregions.org/feed.ttl --retry-count 0
...
fetch:retry Retry https://www.marineregions.org/feed.ttl?page=2023-10-02T11%3A00%3A00Z%2F2023-10-02T12%3A00%3A00Z 114/0 +5ms
fetch:retry Retry http://marineregions.org/mrgid/7494?t=1704805889 156/0 +1ms
fetch:retry Retry http://marineregions.org/mrgid/7496?t=1704805889 153/0 +5ms
... I’d also look rename the |
I sit also possible there’s no exponential back-off anymore, and it just retires as fast as possible? |
I think this is fixed now - can you check? |
small cleanup membermanager catch member errors don't error the stream controller on error Failing to fetch a page, is actually fetching an empty page stop emitting when errored better start up and adapt rdf-connect processor Bump version extract-cbd-shape
6302798
to
2d25b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.