Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better http channel #7

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Better http channel #7

merged 4 commits into from
Mar 25, 2024

Conversation

ajuvercr
Copy link
Member

  • custom response code
  • wait for message to be handled before responding to the client

@ajuvercr ajuvercr requested a review from julianrojas87 March 22, 2024 10:49
Copy link
Contributor

@julianrojas87 julianrojas87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand properly that with this change a processor writing to a HTTP channel cannot write more data until the reading processor(s) have processed the previous data input?
If so, this is indeed very useful. I had to implement some tricky input buffering logic in some processors because HTTP channels do not wait.

@ajuvercr
Copy link
Member Author

Do I understand properly that with this change a processor writing to a HTTP channel cannot write more data until the reading processor(s) have processed the previous data input? If so, this is indeed very useful. I had to implement some tricky input buffering logic in some processors because HTTP channels do not wait.

That is correct, if you set that flag (default is still false)

@ajuvercr ajuvercr merged commit a1be863 into master Mar 25, 2024
1 check passed
@ajuvercr ajuvercr deleted the http-wait branch March 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants