Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FASTA writer for QuatSymm multiple alignment #100

Merged
merged 4 commits into from
Jul 24, 2020

Conversation

lafita
Copy link
Collaborator

@lafita lafita commented Jul 20, 2020

Address issue #99

@lafita
Copy link
Collaborator Author

lafita commented Jul 20, 2020

There is some error related to source.rcsb.org - I will have a look and fix tests using the website.

@josemduarte
Copy link
Member

Nice, thanks @lafita

As you noted all access to source.rcsb.org should be discontinued as soon as possible. We are going to be shutting down the service soon. See the related PR in biojava: biojava/biojava#882

@lafita
Copy link
Collaborator Author

lafita commented Jul 21, 2020

Thanks @josemduarte

Would this be fixed by updating to the next BioJava release?
SCOP identifiers are still available through the StructureIdentifier interface right?

@josemduarte
Copy link
Member

Would this be fixed by updating to the next BioJava release?

That should do it. I hope it doesn't take too long for the next release to come.

SCOP identifiers are still available through the StructureIdentifier interface right?

Yes, the Berkeley provider is available but it is slow to initialise.

@lafita
Copy link
Collaborator Author

lafita commented Jul 21, 2020

Ok, in that case I am going to merge this and we can fix the test issues (unrelated to this PR) when we have a new BioJava version.

Copy link
Collaborator

@sbliven sbliven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. It's good to see you're still using the tool!

@josemduarte
Copy link
Member

@lafita regarding new BioJava version and the code I'm removing in biojava/biojava#882, it'd be a good idea to build this project using that biojava branch's snapshot and see if everything is alright. That is to confirm I didn't remove any needed functionality.

@josemduarte
Copy link
Member

@lafita I've tried with biojava with the PR branch biojava/biojava#882 and the project built correctly including tests.

@lafita
Copy link
Collaborator Author

lafita commented Jul 24, 2020

Thanks @josemduarte I am merging it then.

@lafita lafita merged commit e8793b6 into rcsb:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants