-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create FASTA writer for QuatSymm multiple alignment #100
Conversation
There is some error related to source.rcsb.org - I will have a look and fix tests using the website. |
Nice, thanks @lafita As you noted all access to source.rcsb.org should be discontinued as soon as possible. We are going to be shutting down the service soon. See the related PR in biojava: biojava/biojava#882 |
Thanks @josemduarte Would this be fixed by updating to the next BioJava release? |
That should do it. I hope it doesn't take too long for the next release to come.
Yes, the Berkeley provider is available but it is slow to initialise. |
Ok, in that case I am going to merge this and we can fix the test issues (unrelated to this PR) when we have a new BioJava version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. It's good to see you're still using the tool!
@lafita regarding new BioJava version and the code I'm removing in biojava/biojava#882, it'd be a good idea to build this project using that biojava branch's snapshot and see if everything is alright. That is to confirm I didn't remove any needed functionality. |
@lafita I've tried with biojava with the PR branch biojava/biojava#882 and the project built correctly including tests. |
Thanks @josemduarte I am merging it then. |
Address issue #99