Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove commented html block #234

Merged
merged 2 commits into from
Jul 11, 2021
Merged

remove commented html block #234

merged 2 commits into from
Jul 11, 2021

Conversation

Bill-Kunj
Copy link
Collaborator

No description provided.

@Bill-Kunj Bill-Kunj requested review from dckc and David405 July 10, 2021 22:10
Copy link
Contributor

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still like the idea of showing block info on deploy, but I suppose an issue is a better place for the idea, so: #235

meanwhile: consider deleting a related comment while you're at it:

      // TODO? $('#blockInfo').textContent = pprint(block);

@Bill-Kunj
Copy link
Collaborator Author

Bill-Kunj commented Jul 10, 2021

I still like the idea of showing block info on deploy, but I suppose an issue is a better place for the idea, so: #235

meanwhile: consider deleting a related comment while you're at it:

      // TODO? $('#blockInfo').textContent = pprint(block);

Not sure where this code is. Link please? :)
@dckc Removed in efe401d
Please merge.

@Bill-Kunj Bill-Kunj requested a review from dckc July 11, 2021 00:01
@Bill-Kunj Bill-Kunj merged commit b050666 into master Jul 11, 2021
@Bill-Kunj Bill-Kunj deleted the kill-commented-html branch July 11, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants