fix: handle cases when elements are in an iframe #438
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue #427. Related to this other issue on WordPress WordPress/gutenberg#53867
And edge case is when an element exists in an iframe thus the Window object in the iframe will be different from the main Window. Thus thus comparison fails:
keen-slider/src/core/utils.ts
Line 66 in b7aea40
Iframes tend to be used by page builders such as gutenberg, grapesjs (I haven't tested it here), etc. that rely on iframes for isolation. The fix here fixes this issue.
Any edits are welcome.