rpcs: simplify API for BlockService to handle multiple HTTP paths (#5… #3
rcallabyreviewdog.yml
on: push
reviewdog-errors
5m 40s
reviewdog-warnings
3m 41s
Annotations
11 errors and 1 warning
|
reviewdog-warnings:
crypto/stateproof/verifier.go#L101
[Lint Warnings] reported by reviewdog 🐶
G601: Implicit memory aliasing in for loop. (gosec)
Raw Output:
crypto/stateproof/verifier.go:101:4: G601: Implicit memory aliasing in for loop. (gosec)
&r.SigSlot.Sig,
^
|
|
reviewdog-warnings:
ledger/store/trackerdb/generickv/migrations.go#L169
[Lint Warnings] reported by reviewdog 🐶
G601: Implicit memory aliasing in for loop. (gosec)
Raw Output:
ledger/store/trackerdb/generickv/migrations.go:169:23: G601: Implicit memory aliasing in for loop. (gosec)
bad.SetAccountData(&account)
^
|
|
reviewdog-warnings:
ledger/store/trackerdb/sqlitedriver/schema.go#L790
[Lint Warnings] reported by reviewdog 🐶
G601: Implicit memory aliasing in for loop. (gosec)
Raw Output:
ledger/store/trackerdb/sqlitedriver/schema.go:790:55: G601: Implicit memory aliasing in for loop. (gosec)
deleteHash := trackerdb.AccountHashBuilderV6(addr, &state.old, state.oldEnc)
^
|
|
reviewdog-warnings:
ledger/store/trackerdb/sqlitedriver/schema.go#L799
[Lint Warnings] reported by reviewdog 🐶
G601: Implicit memory aliasing in for loop. (gosec)
Raw Output:
ledger/store/trackerdb/sqlitedriver/schema.go:799:52: G601: Implicit memory aliasing in for loop. (gosec)
addHash := trackerdb.AccountHashBuilderV6(addr, &state.new, state.newEnc)
^
|
|
reviewdog-warnings:
ledger/acctdeltas.go#L134
[Lint Warnings] reported by reviewdog 🐶
G601: Implicit memory aliasing in for loop. (gosec)
Raw Output:
ledger/acctdeltas.go:134:83: G601: Implicit memory aliasing in for loop. (gosec)
normalizedAccountBalances[i].EncodedResources[resource.aidx] = protocol.Encode(&resource.ResourcesData)
^
|
|
reviewdog-warnings:
ledger/store/trackerdb/generickv/schema.go#L136
[Lint Warnings] reported by reviewdog 🐶
func `creatableMaxRangePrefix` is unused (unused)
Raw Output:
ledger/store/trackerdb/generickv/schema.go:136:6: func `creatableMaxRangePrefix` is unused (unused)
func creatableMaxRangePrefix(maxIdx basics.CreatableIndex) ([3]byte, [11]byte) {
^
|
|
reviewdog-warnings:
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go#L38
[Lint Warnings] reported by reviewdog 🐶
type `stateProofVerificationReaderWriter` is unused (unused)
Raw Output:
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go:38:6: type `stateProofVerificationReaderWriter` is unused (unused)
type stateProofVerificationReaderWriter struct {
^
|
|
reviewdog-warnings:
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go#L51
[Lint Warnings] reported by reviewdog 🐶
func `makeStateProofVerificationReaderWriter` is unused (unused)
Raw Output:
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go:51:6: func `makeStateProofVerificationReaderWriter` is unused (unused)
func makeStateProofVerificationReaderWriter(q db.Queryable, e db.Executable) *stateProofVerificationReaderWriter {
^
|
|
reviewdog-warnings:
data/transactions/verify/txn.go#L84
[Lint Warnings] reported by reviewdog 🐶
var `errTxGroupInsuffientLsigBudget` is unused (unused)
Raw Output:
data/transactions/verify/txn.go:84:5: var `errTxGroupInsuffientLsigBudget` is unused (unused)
var errTxGroupInsuffientLsigBudget = errors.New("txgroup lsig expectations exceed available budget")
^
|
|
reviewdog-warnings
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
|
reviewdog-warnings
Process completed with exit code 2.
|
|
reviewdog-warnings
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|