Add support for a second keybind per action #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-logs-out-or-shutdown-or-restart gnome-terminator#843 - fixed Plugin SaveLastSessionLayout not saving layout when user logs out or shutdown or restart - signals added
- added get_vte().has_focus() for a valid focussed terminal to return
100% translated source file: 'po/terminator.pot' on 'ru'.
rcalixte
force-pushed
the
multiple_keybinds
branch
13 times, most recently
from
e392cfb
to
961b5a0
Compare
rcalixte
force-pushed
the
multiple_keybinds
branch
from
961b5a0
to
a36a3ff
Compare
rcalixte
force-pushed
the
multiple_keybinds
branch
9 times, most recently
from
bf09d79
to
4f5fba1
Compare
Got the following Warnings when running under python 3.12.1
home/mattrose/Code/terminator/terminatorlib/terminal.py:324: SyntaxWarning: invalid escape sequence '\['
hostchars = "-A-Za-z0-9:\[\]"
/home/mattrose/Code/terminator/terminatorlib/terminal.py:348: SyntaxWarning: invalid escape sequence '\.'
"(www|ftp)[" + hostchars + "]*\.[" + hostchars +
/home/mattrose/Code/terminator/terminatorlib/terminal.py:354: SyntaxWarning: invalid escape sequence '\.'
"[a-zA-Z0-9-]*\.[a-zA-Z0-9][a-zA-Z0-9-]+" +
/home/mattrose/Code/terminator/terminatorlib/terminal.py:359: SyntaxWarning: invalid escape sequence '\^'
"""news:[-A-Z\^_a-z{|}~!"#$%&'()*+,./0-9;:=?`]+@""" +
To fix this, I changed the strings to raw strings to pass to the regex
Got this while testing layouts. Easy fix
Traceback (most recent call last):
File "/home/mattrose/Code/terminator/./terminator", line 137, in <module>
TERMINATOR.layout_done()
File "/home/mattrose/Code/terminator/terminatorlib/terminator.py", line 341, in layout_done
term.ensure_visible_and_focussed()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ensure_visible_and_focussed'
rcalixte
force-pushed
the
multiple_keybinds
branch
from
4f5fba1
to
a8dbaca
Compare
rcalixte
force-pushed
the
multiple_keybinds
branch
2 times, most recently
from
06228fa
to
f191937
Compare
…tions_po-terminator-pot--master_ru Updates for file po/terminator.pot in ru
…ser-session feat: plugin - Save current user layout of all sessions, fixes gnome-terminator#563
…stSessionLayout-not-saving-layout-when-user-logs-out-or-shutdown-or-restart [bug 843] 843-Plugin-SaveLastSessionLayout-not-saving-layout-when-use…
rcalixte
force-pushed
the
multiple_keybinds
branch
from
f191937
to
a7c7073
Compare
…_get_focussed_terminal_always_returns_none [bug 852] - 852-terminator_py_get_focussed_terminal_always_returns_none
fix traceback in layout_done
fix syntax warnings
rcalixte
force-pushed
the
multiple_keybinds
branch
from
a7c7073
to
dcf6443
Compare
Previously, file URIs were lumped in with full uris that would be used for HTTP, FTP, etc. This caused file:/// uri parser to ignore any file with a root dir that had a character that was not a valid hostname character to be ignored.
…not-clickable-if-the-root-dir-has-a-underscore Properly parse file:/// URIs
Modifying code: - terminatorlib/config.py - terminatorlib/keybindings.py - terminatorlib/plugin.py - terminatorlib/preferences.glade - terminatorlib/prefseditor.py - terminatorlib/terminal_popup_menu.py - terminatorlib/window.py Modifying test: - tests/test_prefseditor_keybindings.py Closes gnome-terminator#371
rcalixte
force-pushed
the
multiple_keybinds
branch
from
dcf6443
to
520fd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying code:
Also updating translation files
Closes gnome-terminator#371