Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #271: Add support for <itunes:episodeType> on feed items #278

Closed
wants to merge 2 commits into from
Closed

Fix issue #271: Add support for <itunes:episodeType> on feed items #278

wants to merge 2 commits into from

Conversation

neubig
Copy link

@neubig neubig commented Aug 30, 2024

This pull request fixes #271.

The issue has been successfully resolved. The PR implements support for parsing the itunes:episodeType tag in RSS feeds. Specifically:

  1. The decorateItunes method in the Parser class was updated to parse the itunes:episodeType tag.
  2. A new test file itunes-episode-type.test.js was created to verify the functionality.
  3. The package.json file was updated with the necessary dependencies and test configuration.
  4. Tests were run successfully, confirming that the itunes:episodeType is correctly parsed for both 'full' and 'trailer' types.

This implementation allows users of the RSS parser to access the episodeType property for iTunes podcast feeds, enabling filtering based on episode types as requested in the original issue.

Automatic fix generated by OpenHands 🙌

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Aug 30, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
@neubig neubig closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for <itunes:episodeType> on feed items
1 participant