Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of next.js #64

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Conversation

rrrnld
Copy link
Contributor

@rrrnld rrrnld commented Apr 23, 2021

Roadmap:

  • Fix automatically fixable dependency security issues via npm audit fix
  • Update to most recent caniuse-lite browser database
  • Update to most recent next.js version
  • Update to webpack 5, because it will be the default in upcoming versions of next.js
  • Update to react 17, because it will be the default in upcoming versions of next.js
  • Test all components in the storybook
  • See if this fixes issue Maps not rendered in Edge (v17) on Windows 10 #61

@github-actions
Copy link

github-actions bot commented Apr 23, 2021

Deploy preview for rbb-data-storybook ready!

✅ Preview
https://rbb-data-storybook-galz43vlh-errnesto.vercel.app
https://bugfixhousekeeping-tasks-rbb-data.errnesto.vercel.app

Built with commit e0c6387.
This pull request is being automatically deployed with vercel-action

@sophiamersmann
Copy link
Member

Note: I just updated next.js to version 10 on a starter-based project and got an error that was related to the css-loader. I haven't investigated further, so not entirely sure this was caused by upgrading next (I didn't get this error when upgrading next on the Geburtskliniken project). Well.. thought this might be useful :)

@rrrnld
Copy link
Contributor Author

rrrnld commented Apr 23, 2021

Webpack 5 support is still experimental in storybook even though it seems to work fine in next. I'd postpone the webpack update until it becomes more stable, running two separate webpack versions at the same time actually sounds pretty close to what I imagine hell to be like.

@rrrnld rrrnld requested a review from sophiamersmann April 23, 2021 16:49
@sophiamersmann
Copy link
Member

sophiamersmann commented Apr 23, 2021

I tested this in Lambdatest on Windows 10 + Edge v17

@rrrnld
Copy link
Contributor Author

rrrnld commented Apr 29, 2021

Fair enough! To be honest, rendering the storybook is not a priority in IE. The storybook is part of the developer experience, and I don't see IE playing an important role in that any time soon.

@rrrnld rrrnld changed the title WIP: Update to latest version of next.js Update to latest version of next.js Apr 29, 2021
@rrrnld rrrnld marked this pull request as ready for review April 29, 2021 09:36
@rrrnld rrrnld merged commit 5974c11 into main Apr 29, 2021
@rrrnld rrrnld deleted the bugfix/housekeeping-tasks branch April 29, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants