Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalR Session Management #168

Merged
merged 3 commits into from
Nov 30, 2020
Merged

SignalR Session Management #168

merged 3 commits into from
Nov 30, 2020

Conversation

rbaker26
Copy link
Owner

@rbaker26 rbaker26 commented Nov 30, 2020

Description

This PR adds SignalR functionality to the app.
This will allow the Server to issue a callback to the Client when SAP2 Emulation is ready for more input or is complete.

Motivation and Context

Resolves #153

How Has This Been Tested?

Using SSMS (see screenshots)

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit and integration tests to cover my changes.
  • All new and existing tests passed.
  • I updated the SamVer in the appropriate .csproj file (only for to-master-merges, ask rbaker26 for a release number).

@rbaker26 rbaker26 added this to the v4.0.0-rc milestone Nov 30, 2020
@rbaker26 rbaker26 linked an issue Nov 30, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #168 (4d58dd1) into v4.0.0-rc (ba32ca4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.0.0-rc     #168   +/-   ##
==========================================
  Coverage      87.13%   87.13%           
==========================================
  Files             28       28           
  Lines           1275     1275           
==========================================
  Hits            1111     1111           
  Misses           164      164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba32ca4...4d58dd1. Read the comment docs.

@rbaker26 rbaker26 self-assigned this Nov 30, 2020
Repository owner deleted a comment from github-actions bot Nov 30, 2020
@github-actions
Copy link

BenchmarkDotNet=v0.12.1, OS=ubuntu 18.04
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET Core SDK=3.1.404
  [Host]     : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT
  DefaultJob : .NET Core 3.1.10 (CoreCLR 4.700.20.51601, CoreFX 4.700.20.51901), X64 RyuJIT

Method Mean Error StdDev Ratio RatioSD
EngineRun_HLT 157.0 μs 3.11 μs 4.55 μs 1.00 0.00
EngineRun_LDA170 177.4 μs 3.54 μs 4.60 μs 1.13 0.05
EngineRun_FIB5 917.9 μs 17.85 μs 17.53 μs 5.89 0.20

Repository owner deleted a comment from github-actions bot Nov 30, 2020
@rbaker26 rbaker26 merged commit 55ee374 into v4.0.0-rc Nov 30, 2020
@rbaker26 rbaker26 deleted the SignalR_Test branch November 30, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAP2 Session Controller
2 participants