feat(bq2bq): add spillover date via SQL support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, can you add an example or test that uses this? |
|
Hi @kushsharma , thanks for reviewing. I've added an example in the latest commit a95c38d. |
kushsharma
reviewed
Nov 1, 2021
Comment on lines
+2
to
+3
| TIMESTAMP('__dstart__') as dstart, | ||
| TIMESTAMP('__dend__') as dend, |
There was a problem hiding this comment.
these dstart dend macros won't work now and these will be exact timestamps getting passed to this SQL, we know that right?
Comment on lines
+6
to
+7
| WHERE date >= DATE_SUB('__dstart__', INTERVAL 14 DAY) | ||
| AND date < '__dend__' |
There was a problem hiding this comment.
similarly, these will be exact timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.