Skip to content

Commit

Permalink
fix: do not overwrite the namespace
Browse files Browse the repository at this point in the history
  • Loading branch information
lavkesh committed Nov 22, 2023
1 parent 47a6094 commit 048f458
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
4 changes: 1 addition & 3 deletions modules/firehose/driver_plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ import (

const SourceKafkaConsumerAutoOffsetReset = "SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET"

var (
suffixRegex = regexp.MustCompile(`^([A-Za-z0-9-]+)-([0-9]+)$`)
)
var suffixRegex = regexp.MustCompile(`^([A-Za-z0-9-]+)-([0-9]+)$`)

func (fd *firehoseDriver) Plan(_ context.Context, exr module.ExpandedResource, act module.ActionRequest) (*resource.Resource, error) {
switch act.Name {
Expand Down
1 change: 0 additions & 1 deletion modules/job/driver/plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ func (driver *Driver) planCreate(exr module.ExpandedResource, act module.ActionR
}

func (driver *Driver) planPendingWithConf(conf *config.Config, exr module.ExpandedResource, steps []PendingStep) (*resource.Resource, error) {

Check failure on line 41 in modules/job/driver/plan.go

View workflow job for this annotation

GitHub Actions / golangci-lint

unused-receiver: method receiver 'driver' is not referenced in method's body, consider removing or renaming it as _ (revive)
conf.Namespace = driver.Conf.Namespace
immediately := time.Now()
exr.Resource.Spec.Configs = modules.MustJSON(conf)
exr.Resource.State = resource.State{
Expand Down

0 comments on commit 048f458

Please sign in to comment.