Remove hardcoded styling in plot_histogram (Qiskit#8761)

* Remove hardcoded styling in plot_histogram * black * Add release note * update ref images * Update releasenotes/notes/histogram-style-03807965c3cc2e8a.yaml Co-authored-by: Luciano Bello <[email protected]> * Update qiskit/visualization/counts_visualization.py --------- Co-authored-by: Luciano Bello <[email protected]>
raynelfss · Apr 4, 2024 · 03eb77a · 03eb77a
1 parent f76f692
commit 03eb77a
Show file tree

Hide file tree

Showing 12 changed files with 10 additions and 6 deletions.
diff --git a/qiskit/visualization/counts_visualization.py b/qiskit/visualization/counts_visualization.py
@@ -58,7 +58,7 @@ def _is_deprecated_data_format(data) -> bool:
 
 def plot_histogram(
     data,
-    figsize=(7, 5),
+    figsize=None,
     color=None,
     number_to_keep=None,
     sort="asc",
@@ -296,7 +296,7 @@ def _plotting_core(
 
     # Set bar colors
     if color is None:
-        color = ["#648fff", "#dc267f", "#785ef0", "#ffb000", "#fe6100"]
+        color = plt.rcParams["axes.prop_cycle"].by_key()["color"]
     elif isinstance(color, str):
         color = [color]
 
@@ -350,7 +350,7 @@ def _plotting_core(
                 label = None
         bar_center = (width / 2) * (length - 1)
         ax.set_xticks(all_inds[item] + bar_center)
-        ax.set_xticklabels(labels_dict.keys(), fontsize=14, rotation=70)
+        ax.set_xticklabels(labels_dict.keys(), rotation=70, ha="right", rotation_mode="anchor")
         # attach some text labels
         if bar_labels:
             for rect in rects:
@@ -391,8 +391,6 @@ def _plotting_core(
         ax.invert_xaxis()
 
     ax.yaxis.set_major_locator(MaxNLocator(5))
-    for tick in ax.yaxis.get_major_ticks():
-        tick.label1.set_fontsize(14)
     plt.grid(which="major", axis="y", zorder=0, linestyle="--")
     if title:
         plt.title(title)
@@ -404,7 +402,6 @@ def _plotting_core(
             ncol=1,
             borderaxespad=0,
             frameon=True,
-            fontsize=12,
         )
     if fig:
         matplotlib_close_if_inline(fig)

diff --git a/releasenotes/notes/histogram-style-03807965c3cc2e8a.yaml b/releasenotes/notes/histogram-style-03807965c3cc2e8a.yaml
@@ -0,0 +1,7 @@
+---
+upgrade:
+  - |
+    Removes the hard-coding of style options for :func:`~.plot_histogram`.  This allows
+    Matplotlib style files to be faithfully applied to the figures.  Users looking to go
+    beyond the defaults set by Matplotlib can make their own style files, or pass a
+    Matplotlib ``Axes`` object to ``plot_histogram`` and post-apply any customizations.
diff --git a/test/visual/mpl/graph/references/histogram.png b/test/visual/mpl/graph/references/histogram.png
diff --git a/test/visual/mpl/graph/references/histogram_2_sets_with_rest.png b/test/visual/mpl/graph/references/histogram_2_sets_with_rest.png
diff --git a/test/visual/mpl/graph/references/histogram_color.png b/test/visual/mpl/graph/references/histogram_color.png
diff --git a/test/visual/mpl/graph/references/histogram_desc_value_sort.png b/test/visual/mpl/graph/references/histogram_desc_value_sort.png
diff --git a/test/visual/mpl/graph/references/histogram_hamming.png b/test/visual/mpl/graph/references/histogram_hamming.png
diff --git a/test/visual/mpl/graph/references/histogram_legend.png b/test/visual/mpl/graph/references/histogram_legend.png
diff --git a/test/visual/mpl/graph/references/histogram_multiple_colors.png b/test/visual/mpl/graph/references/histogram_multiple_colors.png
diff --git a/test/visual/mpl/graph/references/histogram_title.png b/test/visual/mpl/graph/references/histogram_title.png
diff --git a/test/visual/mpl/graph/references/histogram_value_sort.png b/test/visual/mpl/graph/references/histogram_value_sort.png
diff --git a/test/visual/mpl/graph/references/histogram_with_rest.png b/test/visual/mpl/graph/references/histogram_with_rest.png