Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hacker-news extension #16749

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update hacker-news extension #16749

wants to merge 2 commits into from

Conversation

russellyeo
Copy link
Contributor

@russellyeo russellyeo commented Jan 31, 2025 •
edited
Loading

Description

Added optional support for saving hacker news articles to Readwise Reader.

Features

  • Securely add your API key via preferences
  • A new Action "Save to Readwise Reader" becomes available after you have added your API key
  • Performing the action will save the URL to your Readwise Reader account via the Readwise Reader API
  • Previously saved articles will show up in the list with a SavedDocument icon

Screenshots

Screenshot 2025-01-31 at 22 02 50 Screenshot 2025-01-31 at 22 04 32 Screenshot 2025-01-31 at 22 03 34 Screenshot 2025-01-31 at 21 56 51

Checklist

@russellyeo
Update hacker-news extension
907e04a 
- Add format script
- Remove force unwrap and unused imports
- Lint
- Add publish script
- Cache saved URLs and show an accessory
- Fix import
- Add documentation
- Only show the save to readwise reader option if the token is set
- Extract readwise logic to new file
- Add action to save article to readwise reader
- Automated add to contributors
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: hacker-news Issues related to the hacker-news extension labels Jan 31, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 31, 2025 •
edited
Loading

Thank you for your contribution! 🎉

🔔 @thomaspaulmann @GastroGeek @sxn @itsnwa you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspaulmann thomaspaulmann Awaiting requested review from thomaspaulmann thomaspaulmann is a code owner

@sxn sxn Awaiting requested review from sxn sxn is a code owner

@itsnwa itsnwa Awaiting requested review from itsnwa itsnwa is a code owner

Assignees
No one assigned
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: hacker-news Issues related to the hacker-news extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russellyeo @raycastbot