Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update year-in-progress extension #16016

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teemusuvinen
Copy link
Contributor

@teemusuvinen teemusuvinen commented Dec 23, 2024

Description

  • Fix small typos in the extension's "Week starts on" setting
  • Use Day type for options param "weekStartsOn" instead of any (gets rid of warning "Unexpected any. Specify a different type")
  • Remove unused Clipboard import

Screencast

Checklist

- Fix settings typos and type of date-fns options params
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: year-in-progress Issues related to the year-in-progress extension labels Dec 23, 2024
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @thomaspaulmann @anothertempore @akshykhade you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days 🎄

@teemusuvinen
Copy link
Contributor Author

Extensions / Check seems to fail with:

💥error  - validate other lock files
pnpm is not supported. Remove the `pnpm-lock.yaml` file and run `npm install` instead

However I didn't add such file, nor do I have it locally after forking the repo using Raycast's "Fork extension" command 🤔 I can see it in Github though https://github.com/raycast/extensions/blob/4bf7dd9c27e125e2258971d54f0c477d0bec0e52/extensions/year-in-progress/pnpm-lock.yaml

@thomaspaulmann @pernielsentikaer any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: year-in-progress Issues related to the year-in-progress extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants