Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Debug PR 49440 #49442

Closed

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Dec 26, 2024

Why are these changes needed?

In this experiment, I performed the following steps:

  1. git reset back to 2.37.0, then let Buildkite build a Python 3.10 wheel. Afterward, I followed Setup Commands not running with Ray Cluster on GCP #46451 (comment) steps, but in the YAML file's setup_commands, I installed this wheel. After execution, errors were observed (some results were False, and some were True).
    1. Wheel link: https://buildkite.com/ray-project/premerge/builds/32438#01940146-c2cd-4271-bf60-b7da5bbc2f3c
    2. image
  2. Applied Attempt to fix GCP autoscaler threading issue #49440 changes, then let Buildkite build another Python 3.10 wheel. Following the same steps in the above comment, I observed that no errors occurred (all results were True).
    1. Wheel link: https://buildkite.com/ray-project/premerge/builds/32440#019401c3-1cc7-47b7-a183-e144e9a7dbb7
    2. image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness added the go add ONLY when ready to merge, run all tests label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants