Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Support nsight.nvtx profiling #49392

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

ruisearch42
Copy link
Contributor

@ruisearch42 ruisearch42 commented Dec 20, 2024

Why are these changes needed?

With the feature flag turned on, Compiled Graph uses nvtx to automatically annotate and profile function calls during each actor's execution loop.
NVTX documentation: https://nvtx.readthedocs.io/en/latest/install.html

Before (no CPU profiling info):
Screenshot 2024-12-23 at 3 47 56 PM

After (with CPU profiling info):
Screenshot 2024-12-23 at 3 48 42 PM

Will add Ray docs in a separate PR.

Related issue number

Part of #49390

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Manually tested the profile is generated and looks good
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ruisearch42 ruisearch42 added the go add ONLY when ready to merge, run all tests label Dec 20, 2024
Signed-off-by: Rui Qiao <[email protected]>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rynewang rynewang merged commit 3cd2b52 into ray-project:master Dec 26, 2024
5 checks passed
srinathk10 pushed a commit that referenced this pull request Jan 3, 2025
With the feature flag turned on, Compiled Graph uses nvtx to
automatically annotate and profile function calls during each actor's
execution loop.

---------

Signed-off-by: Rui Qiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants