Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][KubeRay] Fix broken Istio Jaeger dashboard link #47244

Merged

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

See the description in the corresponding issue for details.

Related issue number

Closes: #47239

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappiness
Copy link
Member Author

@kevin85421 PTAL

@MortalHappiness MortalHappiness force-pushed the docs/#47239-istio-broken-link branch from 3039c57 to e7b2e74 Compare August 21, 2024 10:15
@MortalHappiness
Copy link
Member Author

MortalHappiness commented Aug 21, 2024

I solve this with html tags instead of markdown syntax because there is still an issue in myst-parser. See the issue description for details.

The following is the CI docs build link.

https://anyscale-ray--47244.com.readthedocs.build/en/47244/cluster/kubernetes/k8s-ecosystem/istio.html#step-6-verify-the-auto-mtls-and-l7-observability

@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Aug 21, 2024
@jjyao jjyao merged commit 937f3eb into ray-project:master Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KubeRay] Broken link in istio auto mTLS doc
4 participants