Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][byod/2] move 9 more tests to byod #36002

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 1, 2023

Why are these changes needed?

Move 9 more release tests to byod

For context on why byod is preferrable: https://docs.google.com/document/d/12WU4vpR0jHgOwceoSgPtE4B-B-6mBonnHHiCSMmMNoY/edit

Checks

@can-anyscale can-anyscale changed the base branch from master to can-byod-migrate-01 June 1, 2023 23:39
@can-anyscale can-anyscale force-pushed the can-byod-migrate-01 branch from 1184c0a to 048fa0e Compare June 1, 2023 23:40
@can-anyscale can-anyscale force-pushed the can-byod-migrate-02 branch 5 times, most recently from 22e3ad3 to f7811be Compare June 2, 2023 19:53
@can-anyscale can-anyscale marked this pull request as ready for review June 2, 2023 19:56
@can-anyscale can-anyscale requested a review from a team as a code owner June 2, 2023 19:56
@can-anyscale can-anyscale changed the title Can byod migrate 02 [ci][byod/2] move 9 more tests to byod Jun 2, 2023
@can-anyscale can-anyscale requested a review from aslonnie June 5, 2023 14:44
@ollie-iterators
Copy link

Speaking of the release tests, I've always been wondering, why do the release tests not run as much as the other tests? Does that mean that they never get removed from flakey-tests.ray.io?

@aslonnie
Copy link
Collaborator

aslonnie commented Jun 5, 2023

why do the release tests not run as much as the other tests?

because they are relatively expensive to run.

Does that mean that they never get removed from flakey-tests.ray.io?

not sure what do you mean..

@ollie-iterators
Copy link

why do the release tests not run as much as the other tests?

because they are relatively expensive to run.

Does that mean that they never get removed from flakey-tests.ray.io?

not sure what do you mean..

The tests shown in the image below on https://flakey-tests.ray.io/ with "Show Release Tests" set to Only and "Show All" set to true have no failures and are still shown as flakey tests.
2023-06-05_11-49-01

@aslonnie
Copy link
Collaborator

aslonnie commented Jun 5, 2023

have no failures and are still shown as flakey tests.

that is probably a bug (or at least not desired behavior).. are you interested on fixing it?

The tracker is a static page generator that runs periodically, and the source code is here:
https://github.com/ray-project/travis-tracker-v2

Filed an issue here:
ray-project/travis-tracker-v2#39

Please follow up on that issue if you are interested.

Also, let's stop commenting about the flaky test tracker here, as it is not related to this PR.

Base automatically changed from can-byod-migrate-01 to master June 5, 2023 18:39
@can-anyscale can-anyscale force-pushed the can-byod-migrate-02 branch 2 times, most recently from b6e05e5 to 9b622b7 Compare June 5, 2023 21:55
@richardliaw richardliaw merged commit e5a3359 into master Jun 5, 2023
@richardliaw richardliaw deleted the can-byod-migrate-02 branch June 5, 2023 22:46
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants