-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][byod/2] move 9 more tests to byod #36002
Conversation
1184c0a
to
048fa0e
Compare
22e3ad3
to
f7811be
Compare
Speaking of the release tests, I've always been wondering, why do the release tests not run as much as the other tests? Does that mean that they never get removed from flakey-tests.ray.io? |
because they are relatively expensive to run.
not sure what do you mean.. |
The tests shown in the image below on https://flakey-tests.ray.io/ with "Show Release Tests" set to Only and "Show All" set to true have no failures and are still shown as flakey tests. |
that is probably a bug (or at least not desired behavior).. are you interested on fixing it? The tracker is a static page generator that runs periodically, and the source code is here: Filed an issue here: Please follow up on that issue if you are interested. Also, let's stop commenting about the flaky test tracker here, as it is not related to this PR. |
Signed-off-by: can <[email protected]>
b6e05e5
to
9b622b7
Compare
Signed-off-by: e428265 <[email protected]>
Why are these changes needed?
Move 9 more release tests to byod
For context on why byod is preferrable: https://docs.google.com/document/d/12WU4vpR0jHgOwceoSgPtE4B-B-6mBonnHHiCSMmMNoY/edit
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.