Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Attempt to fix GCP autoscaler threading issue (#49440)
This is an attempt to fix #46451. I believe that the issue is caused by incorrect handling of [`google-api-python-client`](https://github.com/googleapis/google-api-python-client)-library, which is thread-unsafe as per the [documentation](https://googleapis.github.io/google-api-python-client/docs/thread_safety.html). The above-mentioned documentation also describes how the thread-unsafety can be worked around by instantiating separate `httplib2.Http()` object for each thread. Here, I've just slapped the [request build pattern](https://googleapis.github.io/google-api-python-client/docs/thread_safety.html) onto GCP service creation code. I have not yet fully verified whether this works or not as debugging this is slow and quite a pain in the ass. What I have verified though is that the SSL errors that I mentioned in #46451 (comment) and which consistently occurred in `/tmp/ray/session_latest/logs/monitor.out` are now gone. I'm not sure when I have time to get back to this but I'll leave this here in case someone else wants to take a look. Signed-off-by: Kristian Hartikainen <[email protected]>
- Loading branch information