Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor][RayService] Add conditions to RayService #2807

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Refactor][RayService] Add conditions to RayService #2807

wants to merge 3 commits into from
+371 −0

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Jan 23, 2025 •
edited
Loading

Why are these changes needed?

This PR implements Ready and UpgradeInProgress conditions for RayService.

Related issue number

Closes: #2751

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness force-pushed the feature/#2751-rayservice-conditions branch 4 times, most recently from 49d64e6 to 5cccedc Compare January 23, 2025 13:24
@MortalHappiness MortalHappiness force-pushed the feature/#2751-rayservice-conditions branch from 03228b6 to 8f6e447 Compare January 24, 2025 17:26
@MortalHappiness MortalHappiness marked this pull request as ready for review January 24, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RayService][Refactor] Add conditions to RayService
2 participants
@MortalHappiness @kevin85421