add nodeSelector and securityContext for apiserver #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @YQ-Wang @han-steve would you mind reviewing this PR? Thanks! |
4 tasks
|
This seems like a duplicate of #2523 |
pengliangml
changed the title
|
In order to interact with other systems, we need to set the UID and GID of ray pods through the apiserver, so new features are added. 1) enhance securityContext fields in go backend, 2) add securityContext python sdk in python frontend. Could you please review again and help merge this PR? Thanks @kevin85421 |
han-steve
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We utilize the combinations of
tolerancesandnodeSelectorto manage which nodes the computing pods would be assigned to. And we also have the apiserver for access control, so it's important to supportnodeSelectorfor apiserver. Could you kindly review and merge this PR? Thanks!Related issue number
None
Checks