Skip to content

Commit

Permalink
Remove preStop hooks from Ray CR Samples (#2724)
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanaoleary authored Jan 10, 2025
1 parent 5db3012 commit fffe778
Show file tree
Hide file tree
Showing 20 changed files with 0 additions and 104 deletions.
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-cluster.autoscaler-v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ spec:
name: dashboard
- containerPort: 10001
name: client
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down
8 changes: 0 additions & 8 deletions ray-operator/config/samples/ray-cluster.autoscaler.large.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,6 @@ spec:
name: dashboard
- containerPort: 10001
name: client
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
workerGroupSpecs:
# the pod replicas in this group typed worker
- replicas: 1
Expand Down Expand Up @@ -139,7 +135,3 @@ spec:
requests:
cpu: 14
memory: 54Gi
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
8 changes: 0 additions & 8 deletions ray-operator/config/samples/ray-cluster.autoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ spec:
name: dashboard
- containerPort: 10001
name: client
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down Expand Up @@ -109,10 +105,6 @@ spec:
containers:
- name: ray-worker
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down
8 changes: 0 additions & 8 deletions ray-operator/config/samples/ray-cluster.complete.large.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ spec:
name: dashboard
- containerPort: 10001
name: client
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
volumeMounts:
- mountPath: /tmp/ray
name: ray-logs
Expand Down Expand Up @@ -100,10 +96,6 @@ spec:
requests:
cpu: 14
memory: 54Gi
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
# use volumeMounts.Optional.
# Refer to https://kubernetes.io/docs/concepts/storage/volumes/
volumeMounts:
Expand Down
8 changes: 0 additions & 8 deletions ray-operator/config/samples/ray-cluster.complete.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ spec:
name: dashboard
- containerPort: 10001
name: client
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
volumeMounts:
- mountPath: /tmp/ray
name: ray-logs
Expand Down Expand Up @@ -92,10 +88,6 @@ spec:
containers:
- name: ray-worker
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
# use volumeMounts.Optional.
# Refer to https://kubernetes.io/docs/concepts/storage/volumes/
volumeMounts:
Expand Down
8 changes: 0 additions & 8 deletions ray-operator/config/samples/ray-cluster.embed-grafana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ spec:
name: as-metrics # autoscaler
- containerPort: 44227
name: dash-metrics # dashboard
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
volumeMounts:
- mountPath: /tmp/ray
name: ray-logs
Expand Down Expand Up @@ -69,10 +65,6 @@ spec:
containers:
- name: ray-worker
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
volumeMounts:
- mountPath: /tmp/ray
name: ray-logs
Expand Down
8 changes: 0 additions & 8 deletions ray-operator/config/samples/ray-cluster.tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ spec:
name: dashboard
- containerPort: 10001
name: client
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
volumeMounts:
- mountPath: /tmp/ray
name: ray-logs
Expand Down Expand Up @@ -160,10 +156,6 @@ spec:
containers:
- name: ray-worker
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
# use volumeMounts.Optional.
# Refer to https://kubernetes.io/docs/concepts/storage/volumes/
volumeMounts:
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-job.custom-head-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: [ "/bin/sh","-c","ray stop" ]
resources:
limits:
cpu: "1"
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-job.resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.5.0
lifecycle:
preStop:
exec:
command: [ "/bin/sh","-c","ray stop" ]
resources:
requests:
cpu: "200m"
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-job.sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: [ "/bin/sh","-c","ray stop" ]
resources:
limits:
cpu: "1"
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-job.shutdown.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: [ "/bin/sh","-c","ray stop" ]
resources:
limits:
cpu: "1"
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-service.autoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-service.different-port.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ spec:
containers:
- name: llm
image: anyscale/ray-llm:0.5.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "20"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: 1
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-service.mobilenet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray-ml:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: 1
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-service.sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down
4 changes: 0 additions & 4 deletions ray-operator/config/samples/ray-service.text-ml.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ spec:
containers:
- name: ray-worker # must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc'
image: rayproject/ray:2.9.0
lifecycle:
preStop:
exec:
command: ["/bin/sh","-c","ray stop"]
resources:
limits:
cpu: "1"
Expand Down

0 comments on commit fffe778

Please sign in to comment.