V5.2 fix emoji #31
Closed
V5.2 fix emoji #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that talk to OutputStream (where Jackson does the wrong encoding), versus a Writer that wraps the OutputStream (where the writer does the correct encoding). Some TODO remain in the code for other areas that could be affected but unlikely contain these types of characters.
|
todo for the team:
|
|
Hi @apatrida Thank you for contribution. I've created issue on our bug tracker: https://issues.hibernatingrhinos.com/issue/RDBC-503 Once we fix remaining parts + review we can merge. |
|
Duplicate of #32 |
|
@apatrida Fixed in 5.2.1 Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surrogate pairs get mis-encoded by Jackson when it is responsible for the UTF-8 encoding. When writing (via generator or mapper) to an
OutputStreamthis can happen. Writing to a wrappingWriterchanges the responsibility to the writer and not Jackson which fixes the issue.Added a method in the base command class to create a safe generator, then a few additional fixes in areas that were not based on that command class. A few areas are marked with TODO that are not clear if they need attention, since they call
writeValueToBytesmethod which does theOutputStreamproblem internally.See: FasterXML/jackson-core#223